Repository navigation
Commit 71fefde
fix: make PushDownLeafProjections work with unnest (apache#22620)
Closes apache#22615.
`PushDownLeafProjections` throws an error when it tries to push down an
expression through an `Unnest` node. It also tries to push leaf
projections incorrectly for `Unnest` nodes.
This PR makes PushDownLeafProjections never push down leaf expressions
through Unnest nodes. This avoids the code in `try_push_into_inputs`
from calling:
```
let new_node = node.with_new_exprs(node.expressions(), new_inputs)?;
```
on an Unnest node, which doesn't work.
Changing that line is not enough, as even in that case the code in
`try_push_into_inputs` to decide when to push down a projection is not
valid for Unnest nodes, as explained in
apache#22615
In this PR, I only want to make sure that the optimizer works for Unnest
cases, but we could probably do better and allow leaf expressions push
downs when the expression refer to a column that is not being unnested.
Added unit tests and `.slt` tests for these cases.
No
(cherry picked from commit 7a0d026)1 parent 6ea8f1d commit 71fefde
2 files changed
Lines changed: 95 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1157 | 1157 | | |
1158 | 1158 | | |
1159 | 1159 | | |
| 1160 | + | |
| 1161 | + | |
| 1162 | + | |
| 1163 | + | |
| 1164 | + | |
| 1165 | + | |
| 1166 | + | |
1160 | 1167 | | |
1161 | 1168 | | |
1162 | 1169 | | |
| |||
3050 | 3057 | | |
3051 | 3058 | | |
3052 | 3059 | | |
| 3060 | + | |
| 3061 | + | |
| 3062 | + | |
| 3063 | + | |
| 3064 | + | |
| 3065 | + | |
| 3066 | + | |
| 3067 | + | |
| 3068 | + | |
| 3069 | + | |
| 3070 | + | |
| 3071 | + | |
| 3072 | + | |
| 3073 | + | |
| 3074 | + | |
| 3075 | + | |
| 3076 | + | |
| 3077 | + | |
| 3078 | + | |
| 3079 | + | |
| 3080 | + | |
| 3081 | + | |
| 3082 | + | |
| 3083 | + | |
| 3084 | + | |
| 3085 | + | |
| 3086 | + | |
| 3087 | + | |
| 3088 | + | |
| 3089 | + | |
| 3090 | + | |
| 3091 | + | |
| 3092 | + | |
| 3093 | + | |
| 3094 | + | |
| 3095 | + | |
| 3096 | + | |
| 3097 | + | |
| 3098 | + | |
| 3099 | + | |
| 3100 | + | |
| 3101 | + | |
| 3102 | + | |
| 3103 | + | |
3053 | 3104 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1233 | 1233 | | |
1234 | 1234 | | |
1235 | 1235 | | |
| 1236 | + | |
| 1237 | + | |
| 1238 | + | |
| 1239 | + | |
| 1240 | + | |
| 1241 | + | |
| 1242 | + | |
| 1243 | + | |
| 1244 | + | |
| 1245 | + | |
| 1246 | + | |
| 1247 | + | |
| 1248 | + | |
| 1249 | + | |
| 1250 | + | |
| 1251 | + | |
| 1252 | + | |
| 1253 | + | |
| 1254 | + | |
| 1255 | + | |
| 1256 | + | |
| 1257 | + | |
| 1258 | + | |
| 1259 | + | |
| 1260 | + | |
| 1261 | + | |
| 1262 | + | |
| 1263 | + | |
| 1264 | + | |
| 1265 | + | |
| 1266 | + | |
| 1267 | + | |
| 1268 | + | |
| 1269 | + | |
| 1270 | + | |
| 1271 | + | |
| 1272 | + | |
| 1273 | + | |
| 1274 | + | |
| 1275 | + | |
| 1276 | + | |
| 1277 | + | |
| 1278 | + | |
| 1279 | + | |
0 commit comments