Select file (model, IR) directory instead of a single file#286
Merged
sdatkinson merged 2 commits intomainfrom Jun 11, 2023
Merged
Select file (model, IR) directory instead of a single file#286sdatkinson merged 2 commits intomainfrom
sdatkinson merged 2 commits intomainfrom
Conversation
Owner
Author
|
I think I prefer this over #284 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #281 by giving NAM the permission for all of the directory at once.
Picks the first model in the directory to start; use arrows/dropdown menu to go from there.
Known issue: if the first file in the directory is invalid (e.g. a stereo IR), then this doesn't work cf #285 (will fix next)