Cleanup naming of methods and variables#268
Merged
sdatkinson merged 9 commits intosdatkinson:mainfrom Jul 1, 2023
Merged
Conversation
olilarkin
changed the title
olilarkin
changed the title
olilarkin
force-pushed
the
rename-methods
branch
2 times, most recently
from
3a5a3ca to
6092653
Compare
olilarkin
changed the title
olilarkin
force-pushed
the
rename-methods
branch
2 times, most recently
from
98f2f4e to
85ee9a6
Compare
Closed
olilarkin
force-pushed
the
rename-methods
branch
from
c187b68 to
1381522
Compare
Contributor
Author
|
PR updated |
Contributor
Author
|
how about it @sdatkinson? I think it will make the code a lot nicer. :-) will keep on having to redo this PR if it sits around whilst other changes get merged |
sdatkinson
reviewed
Jun 27, 2023
olilarkin
added a commit
to olilarkin/NeuralAmpModelerPlugin
that referenced
this pull request
Jul 1, 2023
* Rename GetNAM()/GetIR() -> StageModel()/StageIR() * Rename mNAM -> mModel * Rename mStagedNAM -> mStagedModel * Rename mFlagRemoveNAM -> mShouldRemoveModel * Rename mFlagRemoveIR -> mShouldRemoveIR * Rename mNewNAMLoadedInDSP -> mNewModelLoadedInDSP * Remove unnecessary CTOR initializers * mNUM_INTERNAL_CHANNELS -> kNumChannelsInternal * Remove unnessecary use of this->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR goes some way to cleaning up the plug-in code, renaming "NAM" methods/variables to "Model" and a few other things. see #267