Fix some wav impulse files would sometimes fail to load ... #63
Merged
sdatkinson merged 1 commit intosdatkinson:mainfrom Jul 14, 2023
Merged
Fix some wav impulse files would sometimes fail to load ... #63sdatkinson merged 1 commit intosdatkinson:mainfrom
sdatkinson merged 1 commit intosdatkinson:mainfrom
Conversation
…16 because the rounded to dword offset calculation was wrong.
fab672000
changed the title
|
Nice find! Just to confirm, BD_HV_Creamback3_mixed.wav, is not loading in the current release version of NAM: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when the subchunk1Size>16 because the rounded to dword offset calculation was wrong.
Now IR's such as BD_HV_Creamback3_mixed.wav (in free pack from Bogren Digital Impulses) load perfectly while other common cases (chunk size = 16) still work fine.