Skip to content

Remove Windows-specific Poetry path instructions from docs/Makefile#912

Merged
dgarcia360 merged 1 commit intomasterfrom
doc-poetry-windows-support
Oct 10, 2023
Merged

Remove Windows-specific Poetry path instructions from docs/Makefile#912
dgarcia360 merged 1 commit intomasterfrom
doc-poetry-windows-support

Conversation

@dgarcia360
Copy link
Copy Markdown
Collaborator

@dgarcia360 dgarcia360 commented Oct 10, 2023

Motivation

From scylladb/scylla-operator#1308 (comment)

Removes the following lines from the Makefile to simplify the set up:

.. code-block::
    # Windows variables
    ifeq ($(OS),Windows_NT)
        POETRY = $(APPDATA)\Python\Scripts\poetry
    endif
.. note::

IMPORTANT: If you are on Windows, ensure that Poetry is configured in your system's PATH.
For guidance on how to add Poetry to your PATH, refer to the Poetry documentation.

@dgarcia360 dgarcia360 force-pushed the doc-poetry-windows-support branch 2 times, most recently from 6d1a652 to 4fb819a Compare October 10, 2023 09:55
@dgarcia360 dgarcia360 force-pushed the doc-poetry-windows-support branch from 4fb819a to dbbde59 Compare October 10, 2023 10:01
@dgarcia360 dgarcia360 changed the title Doc poetry windows support Remove Windows-specific Poetry Path Instructions from docs/Makefile Oct 10, 2023
@dgarcia360 dgarcia360 changed the title Remove Windows-specific Poetry Path Instructions from docs/Makefile Remove Windows-specific Poetry path instructions from docs/Makefile Oct 10, 2023
@dgarcia360 dgarcia360 marked this pull request as ready for review October 10, 2023 10:04
Copy link
Copy Markdown
Collaborator

@annastuchlik annastuchlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've run the preview without any errors or warnings.

@dgarcia360 dgarcia360 merged commit c255368 into master Oct 10, 2023
@dgarcia360 dgarcia360 deleted the doc-poetry-windows-support branch October 10, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants