Skip to content

Update icons#802

Merged
dgarcia360 merged 2 commits intoscylladb:masterfrom
dgarcia360:update-icons
Jun 2, 2023
Merged

Update icons#802
dgarcia360 merged 2 commits intoscylladb:masterfrom
dgarcia360:update-icons

Conversation

@dgarcia360
Copy link
Copy Markdown
Collaborator

@dgarcia360 dgarcia360 commented May 30, 2023

Update with the icons shared by the marketing team.

Tests

New icons within cards:

image

New icons in navbar:

image

@dgarcia360 dgarcia360 requested a review from annastuchlik May 30, 2023 10:50
@dgarcia360 dgarcia360 marked this pull request as ready for review May 30, 2023 10:52
@dgarcia360
Copy link
Copy Markdown
Collaborator Author

@annastuchlik Ready for review

@annastuchlik
Copy link
Copy Markdown
Collaborator

@dgarcia360 The icons in the navbar look great.

My preview doesn't show the new icons (I've cleaned the cache and used incognito mode), but I assume we don't need them here.
Are you going to use them to update this PR? scylladb/scylladb#13559

@dgarcia360
Copy link
Copy Markdown
Collaborator Author

@annastuchlik I've not changed the icons in the homepage in this pull request. I'll include them in scylladb/scylladb#13559 after we update to 1.5

@annastuchlik
Copy link
Copy Markdown
Collaborator

So I thought, but I had to make sure. Thanks.

Copy link
Copy Markdown
Collaborator

@annastuchlik annastuchlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dgarcia360 dgarcia360 merged commit 5849fe2 into scylladb:master Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants