Skip to content

Add like / dislike button#781

Merged
dgarcia360 merged 6 commits intoscylladb:masterfrom
dgarcia360:add-like-dislike-button
May 19, 2023
Merged

Add like / dislike button#781
dgarcia360 merged 6 commits intoscylladb:masterfrom
dgarcia360:add-like-dislike-button

Conversation

@dgarcia360
Copy link
Copy Markdown
Collaborator

@dgarcia360 dgarcia360 commented May 2, 2023

Adds the like / dislike button at the bottom of the page.

@annastuchlik
Copy link
Copy Markdown
Collaborator

I think the wording should be:

Was this page helpful?

Like:
Great! Thanks for your feedback.

Dislike:
Thanks for your feedback! If you have any suggestions on how we can improve, please don't hesitate to create an issue.

@tzach Let me know if you have any comments.

@tzach
Copy link
Copy Markdown
Collaborator

tzach commented May 16, 2023

Maybe

Thanks for your feedback!
Please don't hesitate to create an issue if you have any suggestions on how we can improve.

@annastuchlik
Copy link
Copy Markdown
Collaborator

@dgarcia360 Let's use the wording above. I can't update this PR, so it would be great if you could do it when you can.

@dgarcia360 dgarcia360 marked this pull request as ready for review May 17, 2023 17:03
@dgarcia360 dgarcia360 requested a review from annastuchlik May 17, 2023 17:03
@annastuchlik
Copy link
Copy Markdown
Collaborator

I've run the preview, but it doesn't look as expected on my side.
The wording is unchanged, and the buttons are not there.
image

I've run it on the clean checkout, but the results are the same.

Copy link
Copy Markdown
Collaborator

@annastuchlik annastuchlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dgarcia360 dgarcia360 merged commit 85cc43e into scylladb:master May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants