Skip to content

docs: Add option to skip theme warnings#741

Merged
dgarcia360 merged 3 commits intoscylladb:masterfrom
dgarcia360:skip-filter-warning-option
Apr 4, 2023
Merged

docs: Add option to skip theme warnings#741
dgarcia360 merged 3 commits intoscylladb:masterfrom
dgarcia360:skip-filter-warning-option

Conversation

@dgarcia360
Copy link
Copy Markdown
Collaborator

@dgarcia360 dgarcia360 commented Mar 31, 2023

Option required to update Java and CPP drivers to 1.4.x.

Note that it is not possible to rename some files on these repos since the docs are being synched from an upstream repo.

How to test

The new option is tested in https://github.com/scylladb/sphinx-scylladb-theme/actions/runs/4577000903/jobs/8081874608?pr=741

@dgarcia360 dgarcia360 added the enhancement New feature or request label Mar 31, 2023
fix valdiation tests

fix valdiation tests

fix valdiation tests
@dgarcia360 dgarcia360 force-pushed the skip-filter-warning-option branch from 6679a0e to 87e826c Compare March 31, 2023 16:09
@dgarcia360 dgarcia360 requested a review from annastuchlik March 31, 2023 16:10
@annastuchlik
Copy link
Copy Markdown
Collaborator

I think we can merge it, as there is no other way to test it.
The option name and the allowed value are self-explanatory.

Copy link
Copy Markdown
Collaborator

@annastuchlik annastuchlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dgarcia360 dgarcia360 merged commit 51833d2 into scylladb:master Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants