Enable banner via Google Tag Manager#696
Merged
dgarcia360 merged 4 commits intoscylladb:masterfrom Feb 28, 2023
Merged
Conversation
Collaborator
|
LGTM |
tzach
approved these changes
Feb 28, 2023
Collaborator
|
@dgarcia360 I have no permissions to review this PR, but it has been reviewed by Tzach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the option to enable the banner via Google Tag Manager.
How to test this pull request
To enable the banner, follow these steps to configure the tag via Google Tag Manager:
Log in to Google Tag Manager at https://tagmanager.google.com/.
Open the account assigned to this project:
GTM-T8P2JP.Select Tags from the left sidebar.
Click New and configure the tag with the following settings:
Type: Custom HTML
Body:
Trigger: On initialization on all pages.
Click Save.
Click Submit and fill in the information to release a new version of the tag.
Click Publish.
Clone this pull request, navigate to the docs folder, and run make preview. Open http://127.0.0.1:5500/ in incognito mode to ensure that your browser does not keep any cookies from previous browsing sessions.
You should now see the announcement banner on the website 🎉
IMPORTANT: Once you've done the test, remember to delete the tag so that a banner with a sample text appears on all sites once we release a new version of the theme.
Editing the banner content
You can customize the banner's title, button text, and URL by editing the
contentattribute of the corresponding metakey. For example:To change a property, edit the tag's body accordingly. Once you've made the changes, remember to publish a new version of the tag.
Disabling the banner
To disable the banner, you have two options:
a. Delete the tag on Google Tag Manager.
b. Set the meta attribute
scylladb-docs-hide_bannertotrue.In both cases, remember to publish a new version.