Skip to content

Highlight current project#694

Merged
dgarcia360 merged 2 commits intoscylladb:masterfrom
dgarcia360:highlight-project
Feb 21, 2023
Merged

Highlight current project#694
dgarcia360 merged 2 commits intoscylladb:masterfrom
dgarcia360:highlight-project

Conversation

@dgarcia360
Copy link
Copy Markdown
Collaborator

This pull request:

  1. Highlights the current project on the sidebar:

image

  1. Adds "ScyllaDB Docs" in front of the breadcrumb list:

image

How to test this PR

  1. Clone this PR and go to the docs folder.
  2. Run make preview or make multiversionpreview.
  3. Open http://127.0.0.1:5500/
  4. Check the sidebar and breadcrumbs.

@dgarcia360 dgarcia360 added the enhancement New feature or request label Feb 14, 2023
@tzach
Copy link
Copy Markdown
Collaborator

tzach commented Feb 14, 2023

I think its the right direction
Not sure about the look when there is no version box (below), but we can improve it later
image

@annastuchlik
Copy link
Copy Markdown
Collaborator

The breadcrumbs look great.

The project name now renders differently - it's not in bold. As a result, if there's no version drop-down, it looks as if it was part of the page tree:

image

Could you modify the project name to make it bold and bigger, or anything else that would clearly differentiate the project name from the page tree?

@dgarcia360
Copy link
Copy Markdown
Collaborator Author

@annastuchlik This seems to be related with cache. Could you please try cleaning the browser cache or opening the site in a new incognito window?

@annastuchlik
Copy link
Copy Markdown
Collaborator

@dgarcia360 Sorry for the confusion. It looks good.

Copy link
Copy Markdown
Collaborator

@annastuchlik annastuchlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dgarcia360 dgarcia360 merged commit d01f84c into scylladb:master Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants