Reset top banner local storage entry every 30 days#651
Merged
dgarcia360 merged 2 commits intoscylladb:masterfrom Dec 13, 2022
Merged
Reset top banner local storage entry every 30 days#651dgarcia360 merged 2 commits intoscylladb:masterfrom
dgarcia360 merged 2 commits intoscylladb:masterfrom
Conversation
dgarcia360
changed the title
tzach
reviewed
Dec 10, 2022
tzach
reviewed
Dec 10, 2022
tzach
reviewed
Dec 10, 2022
|
|
||
| export const onCloseBanner = () => { | ||
| $(".promo-banner__close").on("click", function () { | ||
| setItemWithExpiry(localStorageKey, "1", 30); |
Collaborator
There was a problem hiding this comment.
can we move this value to config.py?
Collaborator
Author
There was a problem hiding this comment.
It is possible. If necessary, we can work on it as part of a separate issue.
annastuchlik
approved these changes
Dec 12, 2022
Collaborator
annastuchlik
left a comment
annastuchlik
left a comment
There was a problem hiding this comment.
LGTM.
I've followed the testing procedure in the description of this PR.
Collaborator
|
This PR can be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #639
How to test this PR
docs/conf.py, sethtml_theme_options.hide_bannerto"false".docsfolder.make previewWhen a page is rendered, the theme checks if the current date is greater than the expiry date to invalidate the entry.