Skip to content

Remove Cloud app from header#649

Merged
dgarcia360 merged 1 commit intoscylladb:masterfrom
dgarcia360:edit-header
Dec 8, 2022
Merged

Remove Cloud app from header#649
dgarcia360 merged 1 commit intoscylladb:masterfrom
dgarcia360:edit-header

Conversation

@dgarcia360
Copy link
Copy Markdown
Collaborator

@dgarcia360 dgarcia360 commented Dec 8, 2022

Closes #648

How to test this PR

  1. Clone the PR.
  2. Go to the docs folder.
  3. Run make preview.
  4. Open http://localhost:5500/
  5. See the new header:

image

@dgarcia360 dgarcia360 added the enhancement New feature or request label Dec 8, 2022
@annastuchlik
Copy link
Copy Markdown
Collaborator

@annastuchlik
Copy link
Copy Markdown
Collaborator

@AdarBahar FYI

Copy link
Copy Markdown
Collaborator

@annastuchlik annastuchlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dgarcia360 dgarcia360 merged commit 1188016 into scylladb:master Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove cloud app from header

2 participants