Skip to content

Update "Edit this page" opens default branch#643

Merged
dgarcia360 merged 3 commits intoscylladb:masterfrom
dgarcia360:edit-this-page-default
Dec 8, 2022
Merged

Update "Edit this page" opens default branch#643
dgarcia360 merged 3 commits intoscylladb:masterfrom
dgarcia360:edit-this-page-default

Conversation

@dgarcia360
Copy link
Copy Markdown
Collaborator

@dgarcia360 dgarcia360 commented Dec 8, 2022

Closes #642

How to test this PR

  1. Clone the PR.
  2. Go to the docs folder.
  3. Run make preview
  4. Open http://127.0.0.1:5500/getting-started/
  5. Click on the "Edit this page" button
  6. The URL should be "github.com/scylladb/sphinx-scylladb-theme/edit/master/docs/source/getting-started/index.rst"

@dgarcia360 dgarcia360 requested a review from tzach December 8, 2022 10:37
@dgarcia360 dgarcia360 added the enhancement New feature or request label Dec 8, 2022
@dgarcia360 dgarcia360 changed the title Update "edit this page" opens default branch Update "Edit this page" opens default branch Dec 8, 2022
Copy link
Copy Markdown
Collaborator

@annastuchlik annastuchlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dgarcia360 dgarcia360 merged commit d780717 into scylladb:master Dec 8, 2022
@dgarcia360 dgarcia360 deleted the edit-this-page-default branch December 8, 2022 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Edit this page button should open default branch

2 participants