Skip to content

Fix Adding a label to a heading breaks the page menu#624

Merged
dgarcia360 merged 2 commits intoscylladb:masterfrom
dgarcia360:fix-labels-sidebar
Nov 25, 2022
Merged

Fix Adding a label to a heading breaks the page menu#624
dgarcia360 merged 2 commits intoscylladb:masterfrom
dgarcia360:fix-labels-sidebar

Conversation

@dgarcia360
Copy link
Copy Markdown
Collaborator

Closes #613

How to test this PR

  1. Clone this pull request.

  2. Run make preview

  3. Open http://127.0.0.1:5500/examples/labels/. You should not see "Beta" next to "Usage" on the right sidebar:

image

If you still see "Beta", please make sure to clean your browser's cache and refresh the page.

@dgarcia360 dgarcia360 added the bug Something isn't working label Nov 15, 2022
Copy link
Copy Markdown
Collaborator

@annastuchlik annastuchlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dgarcia360 dgarcia360 merged commit b42fd2a into scylladb:master Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adding a label to a heading breaks the page menu

2 participants