Skip to content

Show one version in dropdown#546

Merged
dgarcia360 merged 1 commit intoscylladb:masterfrom
dgarcia360:show-one-version-sidebar
Aug 16, 2022
Merged

Show one version in dropdown#546
dgarcia360 merged 1 commit intoscylladb:masterfrom
dgarcia360:show-one-version-sidebar

Conversation

@dgarcia360
Copy link
Copy Markdown
Collaborator

@dgarcia360 dgarcia360 commented Aug 12, 2022

Closes #545

How to test this PR

  1. Clone this PR.
  2. Edit the BRANCHES arrray in https://github.com/scylladb/sphinx-scylladb-theme/blob/master/docs/source/conf.py#L15 as follows to leave one version:

BRANCHES = ["branch-1.2"]

  1. Run make multiversionpreview and open http://localhost:5500. You should see the multiversion dropdown with one version.

@dgarcia360 dgarcia360 force-pushed the show-one-version-sidebar branch from c83bf03 to 708972b Compare August 12, 2022 17:58
Copy link
Copy Markdown
Collaborator

@annastuchlik annastuchlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dgarcia360 dgarcia360 merged commit e2b67f3 into scylladb:master Aug 16, 2022
@dgarcia360 dgarcia360 deleted the show-one-version-sidebar branch August 16, 2022 09:45
dgarcia360 added a commit that referenced this pull request Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Do not hide the multiversion dropdown if there is only one version

2 participants