Added substitutions extension#53
Added substitutions extension#53dgarcia360 merged 7 commits intoscylladb:masterfrom dgarcia360:substitutions
Conversation
| @@ -0,0 +1,101 @@ | |||
| """ | |||
There was a problem hiding this comment.
Any reason not to install this with PyPi like we do for all other extension?
There was a problem hiding this comment.
The original extension reads all the extensions listed in the file conf.py and raises a warning if sphinx-prompts does not exist (lines 25-30).
However, the theme loads dependencies dynamically to have to list them in every ScyllaDB documentation project. Due to how the extension is coded, installing the original extension as is would cause to install the dependency sphinx-prompts in every documentation project individually.
This does not look right since ScyllaDB docs do not use sphinx-prompts at all to display code chunks, but code-blocks. Instead, I have opted to remove the prompts directive support by adapting the extension code.
|
@dgarcia360 there are conflicts which need resolution here |
|
@lauranovich Fixed the merge conflicts. |
…heme into substitutions
|
conflicts need to be resolved here ... @dgarcia360 @tzach ? |
|
@lauranovich Applied the latest changes to this branch. |
Closes #35
To make it work on the main docs, I'll need to publish the theme to PyPi and submit an additional PR to
scylladb/scylla-docsupdating the version.