Add searchbox to herobox#472
Merged
dgarcia360 merged 1 commit intoscylladb:masterfrom May 17, 2022
Merged
Conversation
Collaborator
|
The search is working as expected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #466
Preview: https://www.loom.com/share/fa2c87ac70e54d038abfeaefb4f63191
How to test this PR
Make the docs with "make preview".
Open http://127.0.0.1:5500/examples/hero-box/#hero-box-with-search-box
Test the component.
To enable the searchbox on Scylla docs site, I'll submit another PR adding the
:search_box:option to the directivehero_boxonce we release a new version of the theme.