Fix canonical tag#406
Merged
dgarcia360 merged 1 commit intoscylladb:masterfrom Mar 19, 2022
Merged
Conversation
|
✔️ Deploy Preview for sphinx-theme canceled. 🔨 Explore the source changes: b7e1c30 🔍 Inspect the deploy log: https://app.netlify.com/sites/sphinx-theme/deploys/62338707b706080008233ce9 |
annastuchlik
approved these changes
Mar 18, 2022
Collaborator
annastuchlik
left a comment
annastuchlik
left a comment
There was a problem hiding this comment.
I don't think we can check it with the preview, but the changes look good to me.
Collaborator
|
@dgarcia360 not sure I understand the change |
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #405
Adds dynamically the correct canonical URL:
If multiversion is set, the canonical URL has the form:
<link rel="canonical" href="{{ html_baseurl }}/{{latest_slug}}/{{ pagename }}.html"/>Otherwise:
<link rel="canonical" href="{{ html_baseurl }}/{{ pagename }}.html"/>