Skip to content

Fix top bar blink#382

Merged
dgarcia360 merged 2 commits intoscylladb:masterfrom
dgarcia360:fix-topbar-blink
Mar 4, 2022
Merged

Fix top bar blink#382
dgarcia360 merged 2 commits intoscylladb:masterfrom
dgarcia360:fix-topbar-blink

Conversation

@dgarcia360
Copy link
Copy Markdown
Collaborator

If a project has the top-bar enabled, but the user closes it, the bar continues appearing for milliseconds when the user navigates through the site.

image

To reproduce the bug:

  1. Enter https://sphinx-theme.scylladb.com/stable/
  2. Close the topbar.
  3. Refresh the page with F5 several times.

You will see the topbar for a short period of time.

This PR prevents this bug from happening.

@dgarcia360 dgarcia360 added the bug Something isn't working label Feb 26, 2022
@dgarcia360 dgarcia360 requested a review from tzach February 26, 2022 10:52
@netlify
Copy link
Copy Markdown

netlify Bot commented Feb 26, 2022

@dgarcia360 dgarcia360 added this to the 1.2 milestone Mar 1, 2022
@dgarcia360 dgarcia360 merged commit 9517eeb into scylladb:master Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant