Add substitutions extension as third-party dependency#372
Merged
dgarcia360 merged 2 commits intoscylladb:masterfrom Mar 4, 2022
Merged
Add substitutions extension as third-party dependency#372dgarcia360 merged 2 commits intoscylladb:masterfrom
dgarcia360 merged 2 commits intoscylladb:masterfrom
Conversation
dgarcia360
force-pushed
the
master
branch
2 times, most recently
from
1cf4aff to
6523078
Compare
|
✔️ Deploy Preview for sphinx-theme ready! 🔨 Explore the source changes: 08800b4 🔍 Inspect the deploy log: https://app.netlify.com/sites/sphinx-theme/deploys/6221f5d2642f220007867904 😎 Browse the preview: https://deploy-preview-372--sphinx-theme.netlify.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
In #53 (comment), I included the extension
Sphinx-Substitution-Extensionswith some modifications instead of installing it with PIP because it required a third-party dependency we didn't need to install.I've contributed to the original repository with the changes we applied adamtheturtle/sphinx-substitution-extensions#288, so now we can get rid of the custom extension.
How to test this PR
make preview.The example under
Substitutions within code blocksmust render without errors.