Add collapsible sidebar#258
Merged
dgarcia360 merged 7 commits intoscylladb:masterfrom Dec 8, 2021
Merged
Conversation
Collaborator
|
Two points to consider:
|
Collaborator
Author
We can try with another icon, for example:
I'll keep you posted once I update the PR.
Good catch! Fixed with the latest commit, please run |
Collaborator
Author
|
@tzach Collapsible button updated with round borders and new icon. Preview:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #193
I moved the selector to the bottom and inside the sidebar to not have conflicts with the scrollbar or the multiversion selector.
How to test this PR
Clone this PR. For more information, see Cloning pull requests locally.
Enter the docs folder, and run:
The sidebar collapsed should look like:
The sidebar expanded should look like: