Skip to content

Update sidebar design#250

Merged
dgarcia360 merged 1 commit intomasterfrom
redesign-sidebar-dropdown
Nov 25, 2021
Merged

Update sidebar design#250
dgarcia360 merged 1 commit intomasterfrom
redesign-sidebar-dropdown

Conversation

@dgarcia360
Copy link
Copy Markdown
Collaborator

@dgarcia360 dgarcia360 commented Nov 24, 2021

Closes #247

Removes the "+/-" icons, and adds a triangle instead.

How to preview this PR

  1. Clone this PR. For more information, see Cloning pull requests locally.

  2. Enter the docs folder, and run:

make preview
  1. Open http://127.0.0.1:5500/ with your favorite browser, and enter an internal page. The sidebar should look as follows:

option_b

@dgarcia360 dgarcia360 requested a review from tzach November 24, 2021 20:00
@dgarcia360 dgarcia360 mentioned this pull request Nov 24, 2021
Closed
2 tasks
tzach
tzach approved these changes Nov 24, 2021
View reviewed changes
Copy link
Copy Markdown
Collaborator

@tzach tzach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dgarcia360 dgarcia360 merged commit f379053 into master Nov 25, 2021
@dgarcia360 dgarcia360 deleted the redesign-sidebar-dropdown branch November 25, 2021 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tzach tzach tzach approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update sidebar design

2 participants

@dgarcia360 @tzach