Add enlarge images button#248
Merged
dgarcia360 merged 2 commits intomasterfrom Nov 19, 2021
Merged
Conversation
Collaborator
|
When I test this localy, clicking the image send me to http://localhost:5500/_images/diagram.svg |
Collaborator
|
Do we need to add directive to each image to support this? |
Collaborator
|
Collaborator
|
|
Collaborator
|
Make this option default for all images with |
Collaborator
|
Nice example from stripe: No "resize" button, rather a hover icon |
Collaborator
Author
|
@tzach I've updated the PR with a new proposal. You can test it pulling the latest commit. If it does not work as expected, please remove the cache or open the documentation site in incognito mode. |
Collaborator
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #187
How to test this PR
Clone this PR. For more information, see Cloning pull requests locally.
Enter the docs folder, and run:
Screenshots