Skip to content

Remove bg panel-box#245

Merged
dgarcia360 merged 1 commit intoscylladb:masterfrom
dgarcia360:remove-bg-panel-boxes
Nov 10, 2021
Merged

Remove bg panel-box#245
dgarcia360 merged 1 commit intoscylladb:masterfrom
dgarcia360:remove-bg-panel-boxes

Conversation

@dgarcia360
Copy link
Copy Markdown
Collaborator

Removes the panel box background.

Before

image

Now

image

@dgarcia360 dgarcia360 requested a review from tzach November 10, 2021 15:04
@dgarcia360
Copy link
Copy Markdown
Collaborator Author

I've also tried with a border, but it does not look nice imo:

image

@tzach
Copy link
Copy Markdown
Collaborator

tzach commented Nov 10, 2021

Look better without the border IMHO.
What do you think?

@dgarcia360
Copy link
Copy Markdown
Collaborator Author

dgarcia360 commented Nov 10, 2021

I prefer the version without the border (white background). It looks much cleaner.

@dgarcia360 dgarcia360 added this to the 1.1 milestone Nov 10, 2021
@tzach
Copy link
Copy Markdown
Collaborator

tzach commented Nov 10, 2021

LGTM (with out the border)

@dgarcia360 dgarcia360 merged commit fa6aeca into scylladb:master Nov 10, 2021
@dgarcia360 dgarcia360 deleted the remove-bg-panel-boxes branch November 10, 2021 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants