Add external links icons to sidebar and topic boxes#231
Merged
dgarcia360 merged 2 commits intoscylladb:masterfrom Oct 24, 2021
Merged
Add external links icons to sidebar and topic boxes#231dgarcia360 merged 2 commits intoscylladb:masterfrom
dgarcia360 merged 2 commits intoscylladb:masterfrom
Conversation
Contributor
|
@dgarcia360 - for consistency can we have the icon be the same? Is this possible? |
Collaborator
Author
|
@lauranovich Good catch, I've updated the topic box icon with the latest commit:
|
Collaborator
|
@dgarcia360 for the future it would help me review if you can keep each PR, or at least each commit, on on topic (e.g. fix breadcrumbs, or fix external link) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #227 and #216
How to test this PR
Clone this PR. For more information, see Cloning pull requests locally.
Enter the docs folder, and run:
Open http://127.0.0.1:5500/ with your favorite browser, and navigate to Examples > Topic Box.
Under the heading "Topic box with external link", you will see a topic box with an external link icon. If you click on the topic box, the link will open in a new tab:
TIP: If you don't see the icons the first time you run
make preview, try cleaning your browser's cache.