Skip to content

Complete guide#226

Merged
dgarcia360 merged 3 commits intoscylladb:masterfrom
dgarcia360:complete-guide
Oct 6, 2021
Merged

Complete guide#226
dgarcia360 merged 3 commits intoscylladb:masterfrom
dgarcia360:complete-guide

Conversation

@dgarcia360
Copy link
Copy Markdown
Collaborator

@dgarcia360 dgarcia360 commented Oct 3, 2021

Closes #224, closes scylladb/scylla-doc-issues#801, closes #228

  • Adds correct indentation for Makefile example.
  • Adds the missing variable TESTSPHINXOPTS for the Makefile.
  • Adds how to test if everything worked fine.
  • Adds a note to remove expertrec from conf.py.
  • Adds reference documentation for the custom directives.

@dgarcia360
Copy link
Copy Markdown
Collaborator Author

@lauranovich @tzach I've added:

  • a note to remove expertrec from conf.py.
  • detailed reference documentation for the custom directives.

Could you please review this PR? Thanks!

Copy link
Copy Markdown
Collaborator

@tzach tzach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dgarcia360 dgarcia360 merged commit 7432684 into scylladb:master Oct 6, 2021
@dgarcia360 dgarcia360 deleted the complete-guide branch October 6, 2021 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New theme is missing expertrec.js a few issues with the new theme Issue in page Migrating from 0.x to 1.0

2 participants