Skip to content

Highlight home page on breadcrumbs#214

Merged
dgarcia360 merged 1 commit intoscylladb:masterfrom
dgarcia360:breadcrumb-highlight
Sep 29, 2021
Merged

Highlight home page on breadcrumbs#214
dgarcia360 merged 1 commit intoscylladb:masterfrom
dgarcia360:breadcrumb-highlight

Conversation

@dgarcia360
Copy link
Copy Markdown
Collaborator

Closes #211

How to test this PR

  1. Clone this PR. For more information, see Cloning pull requests locally.

  2. Enter the docs folder, and run:

make preview
  1. Open http://127.0.0.1:5500/ with your favorite browser, and navigate to an internal page. You will see the new breadcrumbs design:

image

@tzach
Copy link
Copy Markdown
Collaborator

tzach commented Sep 29, 2021

For sure better than what we have now

Copy link
Copy Markdown
Collaborator

@tzach tzach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lauranovich
Copy link
Copy Markdown
Contributor

Let's merge it!

@dgarcia360 dgarcia360 merged commit d2a771b into scylladb:master Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Home link should be more visible

3 participants