Add icons#141
Merged
dgarcia360 merged 2 commits intoscylladb:new-designfrom Mar 15, 2021
dgarcia360:add-icons
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue #127
Adds icons for the header navigation, search-box, footer, and contents.
It might be more challenging to add them on the sidebar since Sphinx generates it automatically with little room for customization. For this reason, I'm also evaluating how we could create a custom extension that overrides the default logic to make the icons show up in the sidebar when defined with a directive on the documentation page.