Skip to content

feat: override multiversion redirect#1329

Merged
dgarcia360 merged 1 commit intomasterfrom
configure-redirect-path
Jan 14, 2025
Merged

feat: override multiversion redirect#1329
dgarcia360 merged 1 commit intomasterfrom
configure-redirect-path

Conversation

@dgarcia360
Copy link
Copy Markdown
Collaborator

Motivation

Adds an option to override the multiversion redirect for the main domain.

It is particularly useful for redirecting docs.scylladb.com/manual to docs.scylladb.com/manual/stable instead of docs.scylladb.com/stable.

How to test

  1. Open docs/conf.py.

  2. Define a custom redirect in html_theme_options as follows:

    html_theme_options = {
        "redirect": "/manual/stable",
    }
  3. Build the documentation using make multiversionpreview.

  4. Verify that http://localhost:5500/ redirects to /manual/stable instead of /stable.

@annastuchlik
Copy link
Copy Markdown
Collaborator

It does redirect to /manual/stable (with 404).

Copy link
Copy Markdown
Collaborator

@annastuchlik annastuchlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dgarcia360 dgarcia360 merged commit 3cc67a5 into master Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants