Skip to content

UI update#1314

Merged
dgarcia360 merged 19 commits intoscylladb:masterfrom
kwiato:UI-update
Dec 31, 2024
Merged

UI update#1314
dgarcia360 merged 19 commits intoscylladb:masterfrom
kwiato:UI-update

Conversation

@kwiato
Copy link
Copy Markdown
Contributor

@kwiato kwiato commented Dec 19, 2024

No description provided.

@dgarcia360
Copy link
Copy Markdown
Collaborator

dgarcia360 commented Dec 20, 2024

Feedback:

@dgarcia360 dgarcia360 self-requested a review December 24, 2024 10:37
@dgarcia360
Copy link
Copy Markdown
Collaborator

LGTM!

I added some edits:

  • Changed anchor icon & updated icons lib
  • Anchor icon is copied on hover + click
  • Add configurable brand variables in conf.py

@dgarcia360
Copy link
Copy Markdown
Collaborator

@annastuchlik ready for review

Copy link
Copy Markdown
Collaborator

@annastuchlik annastuchlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

@tzach
Copy link
Copy Markdown
Collaborator

tzach commented Jan 1, 2025

@kwiato @dgarcia360 in the future, please include before and after UI capture in the PR comments.
It would make review easier. Thanks

@dgarcia360 dgarcia360 mentioned this pull request May 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants