Skip to content

feat: add mermaid.js support#1302

Merged
dgarcia360 merged 4 commits intoscylladb:masterfrom
dgarcia360:docs-add-mermaid
Dec 10, 2024
Merged

feat: add mermaid.js support#1302
dgarcia360 merged 4 commits intoscylladb:masterfrom
dgarcia360:docs-add-mermaid

Conversation

@dgarcia360
Copy link
Copy Markdown
Collaborator

@dgarcia360 dgarcia360 commented Nov 26, 2024 •
edited
Loading

@dgarcia360 dgarcia360 requested review from annastuchlik and removed request for annastuchlik November 26, 2024 11:09
@dgarcia360 dgarcia360 marked this pull request as draft November 26, 2024 11:24
@dgarcia360 dgarcia360 marked this pull request as ready for review November 26, 2024 12:53
@dgarcia360
Copy link
Copy Markdown
Collaborator Author

dgarcia360 commented Nov 26, 2024

@annastuchlik ready for review

@annastuchlik
Copy link
Copy Markdown
Collaborator

annastuchlik commented Dec 3, 2024

@dgarcia360 I'm getting some errors:

Configuration error:
There is a programmable error in your configuration file:

Traceback (most recent call last):
  File "/home/mat77/.cache/pypoetry/virtualenvs/sphinx-scylladb-theme-LGaAq45G-py3.10/lib/python3.10/site-packages/sphinx/config.py", line 529, in eval_config_file
    exec(code, namespace)  # NoQA: S102
  File "/mnt/c/Users/AS/Documents/git-repos/temp/sphinx-scylladb-theme/docs/source/conf.py", line 14, in <module>
    MULTIVERSION_CONFIG = fetch_multiversion_configuration(VERSIONS_URL)
NameError: name 'fetch_multiversion_configuration' is not defined

@dgarcia360
Copy link
Copy Markdown
Collaborator Author

dgarcia360 commented Dec 6, 2024

NameError: name 'fetch_multiversion_configuration' is not defined

It looks like you were trying to build this PR with the conf.py edits we applied for #1303 during our latest call.

Could you please try again, making sure there are no edits in conf.py?

@annastuchlik
Copy link
Copy Markdown
Collaborator

annastuchlik commented Dec 9, 2024

Sorry about that. I've checked this PR on a new workspace and now it's working. Thanks.

annastuchlik
annastuchlik approved these changes Dec 9, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@annastuchlik annastuchlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dgarcia360 dgarcia360 merged commit 7790055 into scylladb:master Dec 10, 2024
@dgarcia360 dgarcia360 deleted the docs-add-mermaid branch December 10, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@annastuchlik annastuchlik annastuchlik approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dgarcia360 @annastuchlik