Skip to content

rm: custom icons#1267

Merged
dgarcia360 merged 2 commits intoscylladb:masterfrom
dgarcia360:remove-custom-icons
Oct 21, 2024
Merged

rm: custom icons#1267
dgarcia360 merged 2 commits intoscylladb:masterfrom
dgarcia360:remove-custom-icons

Conversation

@dgarcia360
Copy link
Copy Markdown
Collaborator

@dgarcia360 dgarcia360 commented Oct 18, 2024

Closes #1221

How to test

  1. Clone the PR and build the docs.
  2. Check the following icons render as expected:

image

image

image
3. Check there are no broken icons

Note

The only project that uses previous icons on the homepage and has multiversion enabled is this one (sphinx-scylladb-theme).

Once we merge this, I'll backport the required changes to previous versions.

Copy link
Copy Markdown
Collaborator

@annastuchlik annastuchlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@annastuchlik
Copy link
Copy Markdown
Collaborator

Looks good to me, but there are conflicts.

@dgarcia360 dgarcia360 merged commit fe15af9 into scylladb:master Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove custom icons

2 participants