fix: blink on dark theme#1260
Merged
dgarcia360 merged 1 commit intoscylladb:masterfrom Oct 18, 2024
Merged
Conversation
annastuchlik
approved these changes
Oct 16, 2024
Collaborator
|
@dgarcia360 I've checked 25+ pages, and most of them behaved as expected. However, two or three pages did blink (in incognito, with clean cache), but it's hard to define a rule on which ones did. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1218
Hides the html main component until the theme mode is resolved.
How to test