chore: replace localstorage with cache#1257
Merged
dgarcia360 merged 4 commits intoscylladb:masterfrom Oct 21, 2024
Merged
Conversation
dgarcia360
force-pushed
the
dark-keep-preference
branch
from
de35f0d to
93f6d9d
Compare
annastuchlik
approved these changes
Oct 21, 2024
Collaborator
|
Looks good. Let's release this fix and test it on other projects once the conflicts are resolved in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1230
Closes #1231
This update switches from using local storage to cookies for storing user preferences across different domains. Additionally, it ensures that system preferences for dark mode are respected.
By definition, cookies are shared between domains, whereas local storage is not.
How to test
Testing locally can be challenging since we don't have two projects using the updated theme. However, you can verify that preferences for the dark theme and the expanded bar are retained across domains using the same theme. You can also manually define the dark theme preference in Chrome using this guide.
To perform this test, ensure you're in incognito mode with a clean cache.