Skip to content

fix: tooltip glossary priority#1246

Merged
dgarcia360 merged 2 commits intoscylladb:masterfrom
dgarcia360:fix-tooltip-glossary-priority
Oct 11, 2024
Merged

fix: tooltip glossary priority#1246
dgarcia360 merged 2 commits intoscylladb:masterfrom
dgarcia360:fix-tooltip-glossary-priority

Conversation

@dgarcia360
Copy link
Copy Markdown
Collaborator

Related issue #873

While integrating tooltips into the open-source project, I encountered an issue where the glossary entries were not loading consistently. This was due to their dependency on where the glossary entries were defined and whether Sphinx processed them before or after rendering the tooltips.

This pull request addresses the issue by adding placeholders for all tooltips. Once the glossary entries have been loaded, the placeholders are replaced with the correct values.

Additionally, I have included examples showing how longer tooltips with special characters are rendered.

How to test

  1. Build the documentation.
  2. Go to the Examples > Tooltips page.
  3. Verify that the examples render as expected.

Copy link
Copy Markdown
Collaborator

@annastuchlik annastuchlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks as expected.

@dgarcia360 dgarcia360 merged commit 3c07ba3 into scylladb:master Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants