Some comments:

• Icon not rendering as expected:

• Icon not aligned:

• Icon significant smaller than the previous version -> is it intended?

• Review default label color in light mode:

• Review announcement button color in dark mode:

• Review icons spacing:

• The "User mailing list" icon should not render, we removed it recently:

• Dropdown arrows are smaller -> is it intended?

• Test do not pass. I'll send the fix.

Feedback:

• The "x" button to close the announcement banner has disappeared:

• When navigating between pages in dark mode, the light mode briefly flashes for a few milliseconds. We can work on this as part of a separate PR. To evaluate if it's a blocker for releasing.

• Review the footer in responsive mode:

  

  Before:

  

• It's important to clean up the codebase before the release:

  We are currently defining colors in two separate files: base/_variables.scss and variables/_colors.scss. To improve maintainability, we should consolidate these into a single file. Additionally, we should remove any unused variables and colors.

  Styles are only defined in this project for all projects, so it should be safe to update them as long as we test them. If you'd prefer not to address this in the current PR, we can handle it as part of a separate one.

Fixed tests: 70811e4

Icons that are not using the new icons library:

• Left sidebar expand button (fas fa-bars):
  

• Tables checks (fa fa-check) and cross marks (fa fa-times)
  

• Hero box & topic documentation examples: /examples/hero-box & /examples/topic-box

LGTM. Let's wait for @annastuchlik review before merging.

New issues derived from the changes in this PR:

• Consolidate color variables into a single file #1219
• Brief flash of light mode when navigating between pages in dark mode #1218
• Remove font awesome #1220
• Remove custom icons #1221

To decide if we want to include them in the next release.

@kwiato @dgarcia360 Thank you :) We can now merge and move on :)

@dgarcia360 why cant I see dark node on the Theme site? https://sphinx-theme.scylladb.com/stable/

@tzach We need to merge this PR: #1216
We'll do it today.
The new version contains major changes, so we have do release the new theme with separate PRs.

What I mean is that Dark Theme is part of the new theme that needs to be released yet.