Skip to content

fix: set strict version for sphinx-notfound-page extension#1157

Merged
dgarcia360 merged 1 commit intomasterfrom
fix-notfound-dependency
Jul 31, 2024
Merged

fix: set strict version for sphinx-notfound-page extension#1157
dgarcia360 merged 1 commit intomasterfrom
fix-notfound-dependency

Conversation

@dgarcia360
Copy link
Copy Markdown
Collaborator

See readthedocs/sphinx-notfound-page#240

How to test

Docs should build without issues.

We'll release a new version of the theme to propagate the fix to affected repos.

@dgarcia360 dgarcia360 requested a review from annastuchlik July 30, 2024 16:46
@dgarcia360
Copy link
Copy Markdown
Collaborator Author

Contributed directly to the sphinx-notfound-page extension to fix the issue: readthedocs/sphinx-notfound-page#241.

We might close this PR if the next release of the extension happens before we get to review this PR.

Copy link
Copy Markdown
Collaborator

@annastuchlik annastuchlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants