Skip to content

docs: Python 3.12 compatibility#1123

Merged
dgarcia360 merged 8 commits intoscylladb:masterfrom
dgarcia360:python-3.12-compat
Jul 2, 2024
Merged

docs: Python 3.12 compatibility#1123
dgarcia360 merged 8 commits intoscylladb:masterfrom
dgarcia360:python-3.12-compat

Conversation

@dgarcia360
Copy link
Copy Markdown
Collaborator

@dgarcia360 dgarcia360 commented Jun 25, 2024

Closes #1007

Updates the theme to be compatible with both 3.10 and 3.12 Python versions.

Changes were tested against https://github.com/scylladb/scylladb to ensure it does not introduce breaking changes.

How to test

  1. Go to the docs folder.

  2. With pyenv (Linux and Mac) or pyenvwin (Win), install Python 3.12:

    pyenv install 3.12.2
  3. Set Python 3.12 as the default version:

    pyenv local 3.12.2
  4. Set poetry to use Python 3.12:

    poetry env use python
  5. Build the docs:

    make preview
  6. Ensure the build runs without errors.

  7. Repeat the process with Python 3.10:

    pyenv install 3.10.11
    pyenv local 3.10.11
    poetry env use python
    make preview

@dgarcia360 dgarcia360 requested a review from annastuchlik June 28, 2024 12:41
Copy link
Copy Markdown
Collaborator

@annastuchlik annastuchlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for Python 3.12

2 participants