Skip to content

Add option to open topic-box in same tab#1059

Merged
dgarcia360 merged 2 commits intoscylladb:masterfrom
dgarcia360:extend-panel-box
Apr 5, 2024
Merged

Add option to open topic-box in same tab#1059
dgarcia360 merged 2 commits intoscylladb:masterfrom
dgarcia360:extend-panel-box

Conversation

@dgarcia360
Copy link
Copy Markdown
Collaborator

@dgarcia360 dgarcia360 commented Apr 2, 2024

Adds the option to open topic boxes in the same tabs, even if the link is external.

How to test

  1. Build the docs.
  2. Open http://127.0.0.1:5500/examples/topic-box/#topic-with-external-link-same-tab
  3. The exterrnal link should open on the same tab since it has the :link_target: _self set.

@dgarcia360 dgarcia360 marked this pull request as ready for review April 2, 2024 11:50
@dgarcia360 dgarcia360 requested a review from annastuchlik April 2, 2024 11:50
Copy link
Copy Markdown
Collaborator

@annastuchlik annastuchlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dgarcia360 dgarcia360 merged commit af474c8 into scylladb:master Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants