Extend hero box#1058
Merged
dgarcia360 merged 3 commits intoscylladb:masterfrom Apr 5, 2024
Merged
Conversation
Collaborator
|
@tzach FYI This theme update will make it possible to update the Get Started button on the landing page. It applies the solution you've approved. |
Collaborator
|
Is this change will change all sites or just scylladb-docs-homepage ? |
Collaborator
|
@tzach This PR adds functionality to the Sphinx theme, so it will be applied to all projects. It's configurable, so customization is per project, and you can have different buttons in different projects, as documented here: https://sphinx-theme.scylladb.com/master/examples/hero-box.html |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue scylladb/scylladb-docs-homepage#11
Edits the hero box extension to make the call to action more visible.
How to test
Build the docs.
Open http://127.0.0.1:5500/examples/hero-box/#hero-box-with-everything
Check how the new button will look like: