Improve sidebar: scroll to current page & adjust height#1051
Merged
dgarcia360 merged 6 commits intoscylladb:masterfrom Mar 26, 2024
Merged
Improve sidebar: scroll to current page & adjust height#1051dgarcia360 merged 6 commits intoscylladb:masterfrom
dgarcia360 merged 6 commits intoscylladb:masterfrom
Conversation
Merged
Collaborator
Author
|
Theme / Unit test workflows will be fixed by #1052 |
Collaborator
|
This is a great improvement, and I confirm that the sidebar shows the page I opened, even if it is low on the page tree. However, a page low on the page tree is always displayed as the last item on the menu after it is clicked, making it hard to notice. Is it possible to make the page stay where it is on the menu before it is clicked? An example is below. Before I click "Versions," it is high in the sidebar. After I click "Versions", it jumps to the very bottom (so initially, I couldn't notice it is there, as I didn't expect its position to change). |
Collaborator
Author
|
Thanks, @annastuchlik! I've incorporated your suggestion - now it saves the sidebar scroll position and restoring it when the page loads. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #929
Closes #928
This PR:
How to test