alternator: implement TableClass attribute by changing compression#20520
Draft
nyh wants to merge 1 commit intoscylladb:masterfrom
Draft
alternator: implement TableClass attribute by changing compression#20520nyh wants to merge 1 commit intoscylladb:masterfrom
nyh wants to merge 1 commit intoscylladb:masterfrom
Conversation
NOTE: THIS PATCH IS INCOMPLETE, IT INCLUDES JUST A COMPLETE TEST FOR THIS FEATURE - NOT THE IMPLEMENTATION (WHICH SHOULD BE FAIRLY STRAIGHTFORWARD). DynamoDB announced in December 2021 a new attribute of a table, called table class. The choice of "table class" doesn't change anything in the table's capabilities - it just controls the pricing of storage and access: There are currently two options - STANDARD (the default) and STANDARD_INFREQUENT_ACCESS. The latter is for infrequently-accessed tables, its the data storage costs are lower (in DynamoDB, by 60%), while reads and writes are more expensive (in DynamoDB, by 25%). In this patch we map the TableClass option in Scylla to different sstable compression settings: STANDARD uses to the existing default compression of lz4, which gives reasonable compression ratios at small CPU overhead. STANDARD_INFREQUENT_ACCESS uses zstd compressions, which gives better compression ratios, with higher CPU overhead. TODO: implementation TODO: benchmarks giving example of performance reduction and disk saving Fixes scylladb#10431 Signed-off-by: Nadav Har'El <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: THIS PATCH IS INCOMPLETE, IT INCLUDES JUST A COMPLETE TEST FOR THIS FEATURE - NOT THE IMPLEMENTATION (WHICH SHOULD BE FAIRLY STRAIGHTFORWARD).
DynamoDB announced in December 2021 a new attribute of a table, called table class. The choice of "table class" doesn't change anything in the table's capabilities - it just controls the pricing of storage and access: There are currently two options - STANDARD (the default) and STANDARD_INFREQUENT_ACCESS. The latter is for infrequently-accessed tables, its the data storage costs are lower (in DynamoDB, by 60%), while reads and writes are more expensive (in DynamoDB, by 25%).
In this patch we map the TableClass option in Scylla to different sstable compression settings:
STANDARD uses to the existing default compression of lz4, which gives reasonable compression ratios at small CPU overhead.
STANDARD_INFREQUENT_ACCESS uses zstd compressions, which gives better compression ratios, with higher CPU overhead.
TODO: implementation
TODO: benchmarks giving example of performance reduction and disk saving
Fixes #10431