docs: install poetry>=1.8.0#20286
Closed
tchaikov wants to merge 1 commit intoscylladb:masterfrom
Closed
Conversation
in 57def6f, we specified "package-mode" for poetry, but this option was introduced in poetry 1.8.0, as the "non-package" mode support. see https://github.com/python-poetry/poetry/releases/tag/1.8.0 this change practically bumps up the minimum required poetry version to 1.8.0, we did update `pyproject.tombl` to reflect this change. but wefailed to update the `Makefile`. in this change, we update `Makefile` to ensure that user which happens have an older version of poetry can install the version which supports this version when running `make setupenv`. Refs scylladb#20284 Signed-off-by: Kefu Chai <[email protected]>
tchaikov
added
area/build
documentation
Contributor
Author
|
cc @dgarcia360 |
Contributor
Docs Preview 📖Docs Preview for this pull request is available here Changed Files: Note: This preview will be available for 30 days and will be automatically deleted after that period. You can manually trigger a new build by committing changes. |
denesb
approved these changes
Aug 27, 2024
Collaborator
annastuchlik
left a comment
annastuchlik
left a comment
There was a problem hiding this comment.
I think this change looks good, but I'd like @dgarcia360 to confirm (especially in light of the task in progress to keep poetry.lock per project).
AbhinavKumarJha
pushed a commit
to AbhinavKumarJha/scylladb
that referenced
this pull request
Aug 30, 2024
in 57def6f, we specified "package-mode" for poetry, but this option was introduced in poetry 1.8.0, as the "non-package" mode support. see https://github.com/python-poetry/poetry/releases/tag/1.8.0 this change practically bumps up the minimum required poetry version to 1.8.0, we did update `pyproject.tombl` to reflect this change. but wefailed to update the `Makefile`. in this change, we update `Makefile` to ensure that user which happens have an older version of poetry can install the version which supports this version when running `make setupenv`. Refs scylladb#20284 Signed-off-by: Kefu Chai <[email protected]> Closes scylladb#20286
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in 57def6f, we specified "package-mode" for poetry, but this option was introduced in poetry 1.8.0, as the "non-package" mode support. see https://github.com/python-poetry/poetry/releases/tag/1.8.0
this change practically bumps up the minimum required poetry version to 1.8.0, we did update
pyproject.tomblto reflect this change. but wefailed to update theMakefile.in this change, we update
Makefileto ensure that user which happens have an older version of poetry can install the version which supports this version when runningmake setupenv.Refs #20284
Signed-off-by: Kefu Chai [email protected]
this addresses the build failure of document in an environment where we have an older version of poetry, and this does not impact the production environment, so no need to backport.