docs: edit landing page#13559
Closed
dgarcia360 wants to merge 1 commit intoscylladb:masterfrom
Closed
Conversation
Contributor
Author
|
@annastuchlik could you please review? |
Contributor
Author
|
@annastuchlik Added icons in the top cards:
I've used the same icons the design team shared for the navbar:
|
Collaborator
|
Thanks! Let's use the icons (we can replace them later if needed). Some visuals are helpful. |
Collaborator
|
@tzach Do you want to have a look before the changes are merged? |
Contributor
|
There is something off in the new graphic resolution |
Contributor
Author
|
@tzach I've just sent you and @annastuchlik a message via Slack to coordinate on this matter |
dgarcia360
force-pushed
the
docs-edit-landing-page
branch
from
a5a145c to
16b0959
Compare
docs: add icons docs: update icons
dgarcia360
force-pushed
the
docs-edit-landing-page
branch
from
16b0959 to
e022a36
Compare
Contributor
Author
|
@annastuchlik @tzach icons updated:
|
Collaborator
|
@scylladb/scylla-maint Please merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
I was asked to remove the Scylla monster from the heading. After conducting some tests, I decided to revert part of the changes made in #13167 to maintain consistency with the original design and other documentation projects. Note that ScyllaDB Cloud and Care Pet projects also feature monsters in their headers. Beside, in responsive mode icons are not shown in responsive mode, makign the site
Changes
Reverted partially changes from docs: Add card logos #13167
The original design for product cards was intended for 4 column grids. The CSS has been edited to better support 3 column grids by removing a bit of bottom padding.
Before:
Now:
Prevent the site title from breaking into two lines on large screens.
Before
Now
How to test the pull request
make preview.