-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Closed
Labels
P4Low PriorityLow Priorityarea/alternatorAlternator related IssuesAlternator related Issuesarea/alternator-streamsbackport/noneBackport is not requiredBackport is not requiredgood_first_issue
Milestone
Description
This issue is about minor differences between the fields that Alternator puts in the response of the GetRecords operations - and what DynamoDB returns. All of these differences seem to me minor - perhaps even completely unimportant - but I wanted to explicitly list these differences somewhere (in this issue), and wanted to make a conscious decision whether we believe that those differences will never matter. If that is the case, we can close this issue. If it's not the case, we should fix some or all of these differences.
The differences:
- DynamoDB always sets
eventSourceto the stringaws:dynamodb. We decided to write a different string -scylladb:alternator. This probably makes sense. That is, unless applications may be written to look for thataws:dynamodbvalue? - DynamoDB always sets the
awsRegionfield, we don't set it. I'm worried there may be clients that fail their parsing if this field is missing, even if they don't care about it. Boto3 is perfectly fine with this and other fields being missing in responses, but maybe other clients are not. We could setawsRegionto Scylla, or perhaps even use the current DC's name (which is analogous to DynamoDB's concept of region). - DynamoDB sets the
eventVersionfield to the string1.1. Alternator keeps it unset. Again, could there be clients that fail parsing if this is missing? - DynamoDB sets a
SizeBytessubfield inside thedynamodbfield. Alternator doesn't. I don't know what clients might use this field for, and what happens if it's missing.
CC @elcallio
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
P4Low PriorityLow Priorityarea/alternatorAlternator related IssuesAlternator related Issuesarea/alternator-streamsbackport/noneBackport is not requiredBackport is not requiredgood_first_issue