Skip to content

Docs update theme 1.4#683

Merged
cvybhu merged 3 commits intoscylladb:mainfrom
dgarcia360:docs-update-theme-1.4
Mar 28, 2023
Merged

Docs update theme 1.4#683
cvybhu merged 3 commits intoscylladb:mainfrom
dgarcia360:docs-update-theme-1.4

Conversation

@dgarcia360
Copy link
Copy Markdown
Contributor

Related issue scylladb/sphinx-scylladb-theme#707

ScyllaDB Sphinx Theme 1.4 is now released 🥳

You can read more about all notable changes here.

How to test this PR

  1. Clone this PR. For more information, see Cloning pull requests locally.

  2. Enter the docs folder, and run:

make preview
  1. Open http://localhost:5500 with your favorite browser. The doc should render without errors, and the version should be Sphinx Theme version (see the footer) must be 1.4.x:

image

@dgarcia360 dgarcia360 marked this pull request as draft March 28, 2023 09:11
@dgarcia360 dgarcia360 marked this pull request as ready for review March 28, 2023 09:26
@piodul piodul requested a review from cvybhu March 28, 2023 12:02
Copy link
Copy Markdown
Contributor

@cvybhu cvybhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍
It's a bit sad that we have to change the underscore to a minus sign, this will break existing links to these documentation pages.
Oh well, that's how it's on the internet.

@cvybhu cvybhu merged commit f42367d into scylladb:main Mar 28, 2023
@dgarcia360 dgarcia360 deleted the docs-update-theme-1.4 branch March 28, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants