Update docs theme to 1.0.6 and add CI#886
Merged
zimnx merged 3 commits intoscylladb:masterfrom Jan 5, 2022
Merged
Conversation
tnozicka
added
kind/bug
Contributor
Author
|
hm, we need CI for this |
tnozicka
force-pushed
the
fix-python-deps
branch
2 times, most recently
from
475de5f to
a37686c
Compare
tnozicka
changed the title
Contributor
Author
|
I picked up logical changes from #815 to fix the CI errors and bump our docs theme |
tnozicka
force-pushed
the
fix-python-deps
branch
from
a37686c to
998d936
Compare
tnozicka
added
kind/documentation
tnozicka
force-pushed
the
fix-python-deps
branch
9 times, most recently
from
2cb834e to
4066e3c
Compare
tnozicka
force-pushed
the
fix-python-deps
branch
from
4066e3c to
25bf939
Compare
zimnx
reviewed
Dec 17, 2021
tnozicka
force-pushed
the
fix-python-deps
branch
2 times, most recently
from
5bae84b to
a163338
Compare
zimnx
reviewed
Jan 3, 2022
tnozicka
force-pushed
the
fix-python-deps
branch
from
a163338 to
3d984f0
Compare
zimnx
reviewed
Jan 4, 2022
| .PHONY: multiversion | ||
|
|
||
| .PHONY: multiversionpreview | ||
| multiversionpreview: multiversion |
Contributor
There was a problem hiding this comment.
why is this dependency removed? It doesn't make sense to start server without building sources
Contributor
Author
There was a problem hiding this comment.
you could have built the sources already. if you make it a hard dependency it forces everyone to rebuild before every run, even if nothing changed and it was already built
tnozicka
force-pushed
the
fix-python-deps
branch
9 times, most recently
from
de958d2 to
b15f4cc
Compare
zimnx
reviewed
Jan 5, 2022
Comment on lines
+1
to
+2
| name: "Setup Documentation Essentials and Build" | ||
| description: 'Sets up dependencies and builds the docs' |
Contributor
There was a problem hiding this comment.
Suggested change
| name: "Setup Documentation Essentials and Build" | |
| description: 'Sets up dependencies and builds the docs' | |
| name: "Build documentation and upload artifacts" | |
| description: 'Builds the docs and uploads artifacts' |
| - 'v[0-9]+.[0-9]+' | ||
| paths: | ||
| - 'docs/**' | ||
| - '.github/workflows/docs_build.yaml' |
Contributor
There was a problem hiding this comment.
changes in .github/actions/* won't trigger the build, and should. Maybe entire .github/** should be here and below
Contributor
Author
There was a problem hiding this comment.
yeah, I've changed the path since. I've made it test always, and restricted deploys to .github/**
| # checks out random tips of other branches and the code isn't build just from | ||
| # what triggered the event. For any branch that changes we need to always | ||
| # build and deploy from master :( | ||
| # Triggering a job from multiple branches in parallel is racy, but it's wht we have :( |
Contributor
There was a problem hiding this comment.
Suggested change
| # Triggering a job from multiple branches in parallel is racy, but it's wht we have :( | |
| # Triggering a job from multiple branches in parallel is racy, but it's what we have :( |
tnozicka
force-pushed
the
fix-python-deps
branch
2 times, most recently
from
ff68c03 to
2f12cc8
Compare
tnozicka
force-pushed
the
fix-python-deps
branch
from
2f12cc8 to
c4c74c5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes:
We need to bump vulnerable dependencies. Also the same sources must produce the same results and not randomly pick a new version that can break it.
This also bumps our docs theme to 1.0.6.