Skip to content

Fix build error due to index not including all files #804

Closed
lauranovich wants to merge 3 commits intoscylladb:masterfrom
lauranovich:fix-toc-runtime-error
Closed

Fix build error due to index not including all files #804
lauranovich wants to merge 3 commits intoscylladb:masterfrom
lauranovich:fix-toc-runtime-error

Conversation

@lauranovich
Copy link
Copy Markdown
Contributor

@lauranovich lauranovich commented Oct 6, 2021

FIXES #802

@lauranovich lauranovich changed the title adds glob pattern to TOC to prevent missing toc entry errors. DOCS: adds glob pattern to TOC to prevent missing toc entry errors. Oct 6, 2021
@lauranovich lauranovich added the kind/documentation Categorizes issue or PR as related to documentation. label Oct 6, 2021
@lauranovich lauranovich mentioned this pull request Oct 6, 2021
Closed
@lauranovich lauranovich added this to the v1.6 milestone Oct 6, 2021
@tzach tzach self-requested a review October 6, 2021 11:22
tzach
tzach previously approved these changes Oct 6, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@tzach tzach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dgarcia360
Copy link
Copy Markdown
Contributor

dgarcia360 commented Oct 6, 2021

LGTM, I don't get any errors locally

@zimnx zimnx added kind/documentation Categorizes issue or PR as related to documentation. and removed kind/documentation Categorizes issue or PR as related to documentation. labels Oct 6, 2021
@zimnx zimnx changed the title DOCS: adds glob pattern to TOC to prevent missing toc entry errors. Add glob pattern to table of content to prevent missing entry errors Oct 6, 2021
@zimnx
Copy link
Copy Markdown
Contributor

zimnx commented Oct 6, 2021

For some reason multiversionpreview doesn't pick up this change, but i guess it's related to my local env.
It's visible on regular make preview and unfortunately it doesn't look good.

Selection_271
Entries are not sorted by any context, nor alphabetically.
I think a static list would be better, overall CI should detect and reject any errors in PRs changing docs.

@lauranovich
Copy link
Copy Markdown
Contributor Author

lauranovich commented Oct 6, 2021

@zimnx - sure I can make that change

@lauranovich lauranovich changed the title Add glob pattern to table of content to prevent missing entry errors Fix build error due to index not including all files Oct 6, 2021
@tnozicka tnozicka requested a review from zimnx October 7, 2021 06:28
@tnozicka tnozicka added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Oct 7, 2021
@zimnx
Copy link
Copy Markdown
Contributor

zimnx commented Oct 7, 2021 •
edited
Loading

LGTM, please squash commits to single one before merge

@lauranovich lauranovich mentioned this pull request Oct 10, 2021
Merged
@lauranovich
Copy link
Copy Markdown
Contributor Author

lauranovich commented Oct 10, 2021

closing, replaced with #807

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zimnx zimnx Awaiting requested review from zimnx

1 more reviewer

@tzach tzach tzach left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

kind/documentation Categorizes issue or PR as related to documentation. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@lauranovich @dgarcia360 @zimnx @tzach @tnozicka