Adjust docs development workflow and add developers' README#1323
Merged
zimnx merged 2 commits intoscylladb:masterfrom Aug 16, 2023
Merged
Adjust docs development workflow and add developers' README#1323zimnx merged 2 commits intoscylladb:masterfrom
zimnx merged 2 commits intoscylladb:masterfrom
Conversation
rzetelskik
added
kind/documentation
Contributor
|
Skipping CI for Draft Pull Request. |
scylla-operator-bot
Bot
added
do-not-merge/work-in-progress
rzetelskik
changed the title
Member
Author
|
cc @dgarcia360, I can't request a review for some reason |
scylla-operator-bot
Bot
removed
the
do-not-merge/work-in-progress
Contributor
|
LGTM |
tnozicka
previously approved these changes
Aug 14, 2023
|
|
||
| ## Local preview | ||
|
|
||
| To build the documentation locally, run `make setup` first. |
Contributor
There was a problem hiding this comment.
Suggested change
| To build the documentation locally, run `make setup` first. | |
| To build the documentation locally, run `make setup` first to install its dependencies. |
zimnx
previously approved these changes
Aug 16, 2023
zimnx
approved these changes
Aug 16, 2023
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rzetelskik, zimnx The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes: This PR adds a setup target to docs Makefile and modifies POETRY variable to ensure compatibility for windows, as well as a README for developers as requested in #1308 (comment)
Which issue is resolved by this Pull Request:
Resolves: issues #1308 (comment)