Skip to content

docs: Update theme 1.4.1#1945

Merged
amnonh merged 1 commit intoscylladb:masterfrom
dgarcia360:docs-update-theme-1.4
Apr 4, 2023
Merged

docs: Update theme 1.4.1#1945
amnonh merged 1 commit intoscylladb:masterfrom
dgarcia360:docs-update-theme-1.4

Conversation

@dgarcia360
Copy link
Copy Markdown
Contributor

Related issue scylladb/sphinx-scylladb-theme#707

ScyllaDB Sphinx Theme 1.4 is now released 🥳

You can read more about all notable changes here.

How to test this PR

  1. Clone this PR. For more information, see Cloning pull requests locally.

  2. Enter the docs folder, and run:

make preview
  1. Open http://localhost:5500 with your favorite browser. The doc should render without errors, and the version should be Sphinx Theme version (see the footer) must be 1.4.x:

image

@amnonh
Copy link
Copy Markdown
Collaborator

amnonh commented Apr 4, 2023

@annastuchlik @tzach can one of you please ok this?

@annastuchlik
Copy link
Copy Markdown
Contributor

Sure, I'm on it right now.

@annastuchlik annastuchlik added the documentation Documentation related label Apr 4, 2023
Copy link
Copy Markdown
Contributor

@annastuchlik annastuchlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amnonh amnonh merged commit 6671535 into scylladb:master Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Documentation related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants